-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade instances of com.google.android.play.core #10198
Labels
Comments
7 tasks
metamaskbot
added
the
release-7.30.0
Issue or pull request that will be included in release 7.30.0
label
Aug 15, 2024
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 15, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
added a commit
that referenced
this issue
Aug 19, 2024
…10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
runway-github bot
pushed a commit
that referenced
this issue
Aug 19, 2024
…h SDK 14 on Android (#10647) ## **Description** This PR bumps the in-app review package to comply with the updates to ## **Related issues** Fixes: #10198 ## **Manual testing steps** 1. Build for Android and see successful submission 2. 3. ## **Screenshots/Recordings** NA ### **Before** <img width="1306" alt="Screenshot 2024-08-14 at 3 20 41 PM" src="https://github.com/user-attachments/assets/8e73151f-835e-4e08-b95e-f2224ec4c27a"> ### **After** <img width="1334" alt="Screenshot 2024-08-14 at 3 43 46 PM" src="https://github.com/user-attachments/assets/20ff7630-18c0-47bc-af50-50d26fd6b557"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What is this about?
com.google.android.play:core:1.9.0
Google Play Core (com.google.android.play:core) has added this note for SDK version 1.9.0:
Update your Play Core Maven dependency to an Android 14 compatible version! Your current Play Core library is incompatible with targetSdkVersion 34 (Android 14), which introduces a backwards-incompatible change to broadcast receivers to improve user security. As a reminder, from August 31, Google Play requires all new app releases to target Android 14. Update to the latest Play Core library version dependency to avoid app crashes: https://developer.android.com/guide/playcore#playcore-migration
From September 18, 2024 00:00 (UTC) you won't be able to release new versions of your app containing this SDK version to production or open testing.
Scenario
Design
No response
Technical Details
react-native-in-app-review
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: