Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable smart transactions only for ETH mainnet in production and for ETH mainnet and Sepolia in non-prod #10565

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Aug 12, 2024

Description

Enables STX only for ETH mainnet in production and for ETH mainnet and Sepolia in non-production environments for testing purposes.

Related issues

Fixes:

Manual testing steps

  1. When running a dev build with STX enabled, you will be able to use ETH mainnet and Sepolia for STX. You would see the smart transaction status page after submitting a transaction.
  2. When running a prod build with STX enabled, you will only be able to use ETH mainnet for STX.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Aug 12, 2024
@dan437 dan437 requested review from a team as code owners August 12, 2024 12:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 force-pushed the stx-test-networks branch from bfa863b to ad4db97 Compare August 12, 2024 12:51
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.60%. Comparing base (d7586ee) to head (ad4db97).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10565      +/-   ##
==========================================
- Coverage   50.61%   50.60%   -0.01%     
==========================================
  Files        1516     1518       +2     
  Lines       36188    36225      +37     
  Branches     4182     4200      +18     
==========================================
+ Hits        18317    18333      +16     
- Misses      16680    16686       +6     
- Partials     1191     1206      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan437 dan437 force-pushed the stx-test-networks branch from ad4db97 to 83accad Compare August 13, 2024 11:18
@dan437 dan437 force-pushed the stx-test-networks branch from 83accad to e95c89d Compare August 15, 2024 12:22
@dan437 dan437 requested a review from a team as a code owner August 15, 2024 12:39
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/semver@7.6.3 None 0 95.8 kB npm-cli-ops

🚮 Removed packages: npm/semver@7.6.2

View full report↗︎

@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Aug 15, 2024
Copy link
Contributor

github-actions bot commented Aug 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 929357b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/13d01614-b8aa-43c0-9b6d-2992f3e1a69b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This will definitely help with testing and development.

@dan437 dan437 merged commit 4f27e5b into main Aug 15, 2024
35 of 36 checks passed
@dan437 dan437 deleted the stx-test-networks branch August 15, 2024 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants