Enable STX only for ETH mainnet in production and for ETH mainnet and…

… Sepolia in non-prod

Resolve linting

app/constants/smartTransactions.test.ts

@@ -0,0 +1,33 @@
+import { NETWORKS_CHAIN_ID } from './network';
+import { isProduction } from '../util/environment';
+import { getAllowedSmartTransactionsChainIds } from './smartTransactions';
+
+jest.mock('../util/environment', () => ({
+  isProduction: jest.fn(() => false), // Initially mock isProduction to return false
+}));
+
+// Cast isProduction to jest.Mock to inform TypeScript about the mock type
+const mockIsProduction = isProduction as jest.Mock;
+
+describe('smartTransactions', () => {
+  describe('getAllowedSmartTransactionsChainIds', () => {
+    beforeEach(() => {
+      jest.clearAllMocks();
+    });
+
+    it('returns the correct chain IDs for development environment', () => {
+      mockIsProduction.mockReturnValue(false);
+      const allowedChainIds = getAllowedSmartTransactionsChainIds();
+      expect(allowedChainIds).toStrictEqual([
+        NETWORKS_CHAIN_ID.MAINNET,
+        NETWORKS_CHAIN_ID.SEPOLIA,
+      ]);
+    });
+
+    it('returns the correct chain IDs for production environment', () => {
+      mockIsProduction.mockReturnValue(true);
+      const allowedChainIds = getAllowedSmartTransactionsChainIds();
+      expect(allowedChainIds).toStrictEqual([NETWORKS_CHAIN_ID.MAINNET]);
+    });
+  });
+});

app/constants/smartTransactions.ts

@@ -0,0 +1,18 @@
+/* eslint-disable import/prefer-default-export */
+
+import { isProduction } from '../util/environment';
+import { NETWORKS_CHAIN_ID } from './network';
+
+const ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT: string[] = [
+  NETWORKS_CHAIN_ID.MAINNET,
+  NETWORKS_CHAIN_ID.SEPOLIA,
+];
+
+const ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_PRODUCTION: string[] = [
+  NETWORKS_CHAIN_ID.MAINNET,
+];
+
+export const getAllowedSmartTransactionsChainIds = (): string[] =>
+  isProduction()
+    ? ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_PRODUCTION
+    : ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS_DEVELOPMENT;

app/core/Engine.ts

@@ -207,7 +207,7 @@ import {
   networkIdWillUpdate,
 } from '../core/redux/slices/inpageProvider';
 import SmartTransactionsController from '@metamask/smart-transactions-controller';
-import { NETWORKS_CHAIN_ID } from '../../app/constants/network';
+import { getAllowedSmartTransactionsChainIds } from '../../app/constants/smartTransactions';
 import { selectShouldUseSmartTransaction } from '../selectors/smartTransactionsController';
 import { selectSwapsChainFeatureFlags } from '../reducers/swaps';
 import { SmartTransactionStatuses } from '@metamask/smart-transactions-controller/dist/types';
@@ -1248,11 +1248,7 @@ class Engine {
         trackMetaMetricsEvent: smartTransactionsControllerTrackMetaMetricsEvent,
       },
       {
-        supportedChainIds: [
-          NETWORKS_CHAIN_ID.MAINNET,
-          NETWORKS_CHAIN_ID.GOERLI,
-          NETWORKS_CHAIN_ID.SEPOLIA,
-        ],
+        supportedChainIds: getAllowedSmartTransactionsChainIds(),
       },
       initialState.SmartTransactionsController,
     );

app/selectors/smartTransactionsController.ts

@@ -9,12 +9,8 @@ import {
   SmartTransactionStatuses,
 } from '@metamask/smart-transactions-controller/dist/types';
 import { selectSelectedInternalAccountChecksummedAddress } from './accountsController';
+import { getAllowedSmartTransactionsChainIds } from '../../app/constants/smartTransactions';
 
-export const ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS = [
-  NETWORKS_CHAIN_ID.MAINNET,
-  NETWORKS_CHAIN_ID.GOERLI,
-  NETWORKS_CHAIN_ID.SEPOLIA,
-];
 export const selectSmartTransactionsEnabled = (state: RootState) => {
   const selectedAddress =
     selectSelectedInternalAccountChecksummedAddress(state);
@@ -25,7 +21,7 @@ export const selectSmartTransactionsEnabled = (state: RootState) => {
   const providerConfigRpcUrl = selectProviderConfig(state).rpcUrl;
 
   const isAllowedNetwork =
-    ALLOWED_SMART_TRANSACTIONS_CHAIN_IDS.includes(chainId);
+    getAllowedSmartTransactionsChainIds().includes(chainId);
 
   // E.g. if a user has a Mainnet Flashbots RPC, we do not want to bypass it
   // Only want to bypass on default mainnet RPC

app/util/environment.test.ts

@@ -0,0 +1,24 @@
+import { isProduction } from './environment';
+
+const originalNodeEnvironment = process.env.NODE_ENV;
+
+describe('isProduction', () => {
+  afterAll(() => {
+    process.env.NODE_ENV = originalNodeEnvironment;
+  });
+
+  it('returns true when NODE_ENV is "production"', () => {
+    process.env.NODE_ENV = 'production';
+    expect(isProduction()).toBe(true);
+  });
+
+  it('returns false when NODE_ENV is "development"', () => {
+    process.env.NODE_ENV = 'development';
+    expect(isProduction()).toBe(false);
+  });
+
+  it('returns false when NODE_ENV is "test"', () => {
+    process.env.NODE_ENV = 'test';
+    expect(isProduction()).toBe(false);
+  });
+});

app/util/environment.ts

@@ -0,0 +1,6 @@
+/* eslint-disable import/prefer-default-export */
+
+export const isProduction = (): boolean =>
+  // TODO: process.env.NODE_ENV === 'production' doesn't work with tests yet. Once we make it work,
+  // we can remove the following line and use the code above instead.
+  ({ ...process.env }?.NODE_ENV === 'production');