Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings toggle extra large paddings when biometrics hidden #10547

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Aug 2, 2024

Description

Updating a fix for this merged PR for this issue. When the biometrics and/or passcode toggle fields are hidden there is padding left over which adds more white space into the UI

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the "Security and Privacy" screen
  2. Verify that the toggles now have the correct paddings
  3. Verify that when the biometrics and passcode are hidden there isn't left over padding

Screenshots/Recordings

Before After
Screenshot 2024-08-02 at 12 17 22 PM Screenshot 2024-08-02 at 12 17 26 PM

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested a review from a team as a code owner August 2, 2024 18:39
Copy link
Contributor

github-actions bot commented Aug 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux area-design Design bug (previously known as papercuts - ask Hilary for more detail) labels Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5b44143
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a3ec06c-be3d-485c-93c7-651d4ce60e62

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 self-requested a review August 12, 2024 11:44
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@vinnyhoward vinnyhoward merged commit 91d61fb into main Aug 15, 2024
33 checks passed
@vinnyhoward vinnyhoward deleted the fix-2452-security-privacy-toggle-padding branch August 15, 2024 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) release-7.30.0 Issue or pull request that will be included in release 7.30.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants