Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security and privacy toggle paddings #10488

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jul 30, 2024

Description

This PR corrects the style of two toggles in the "Security and Privacy" screen

Related issues

Fixes: None

Manual testing steps

  1. Go to the "Security and Privacy" screen
  2. Verify that the toggles now have the correct paddings

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr changed the title Fix/sec settings screen fix: security and privacy toggle paddings Jul 30, 2024
@gantunesr gantunesr marked this pull request as ready for review July 30, 2024 22:03
@gantunesr gantunesr requested a review from a team as a code owner July 30, 2024 22:03
@gantunesr gantunesr added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 30, 2024
Copy link

@gantunesr gantunesr added Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 31, 2024
Copy link
Contributor

github-actions bot commented Jul 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e47affd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3ed92db-eec4-4549-b31d-b0a0cd868112

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gantunesr gantunesr merged commit edff39c into main Jul 31, 2024
41 of 43 checks passed
@gantunesr gantunesr deleted the fix/sec-settings-screen branch July 31, 2024 11:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-accounts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants