-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor blockaid metrics sync functions to async #10518
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: c29298c Note
|
Bitrise✅✅✅ Commit hash: 7f8d052 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, I left some small feedbacks to be addressed.
Bitrise✅✅✅ Commit hash: cb5c855 Note
|
Bitrise✅✅✅ Commit hash: bf51625 Note
|
Quality Gate passedIssues Measures |
Description
After this PR to use the Security alert API to get the supported chains via
isChainSupported
which now it's an async function and we saw that it is used across the Blockaid metrics in the mobile client. So this PR aims to refactor every place that uses it to support it asynchronously.Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1893
Related: https://github.com/MetaMask/mobile-planning/issues/1870
Manual testing steps
SEGMENT_WRITE_KEY
will be required to perform this test)Screenshots/Recordings
test-ppom.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist