-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add utility function to get supported chains from the Security Alerts API #10267
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: a5129ef Note
|
There is usage of
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10267 +/- ##
==========================================
+ Coverage 49.67% 49.69% +0.02%
==========================================
Files 1450 1450
Lines 34888 34899 +11
Branches 3950 3952 +2
==========================================
+ Hits 17330 17343 +13
+ Misses 16456 16454 -2
Partials 1102 1102 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: 2a87725 Note
|
I will open a ticket and the refactor will be handled in this PR, cause it was getting too big. |
Quality Gate passedIssues Measures |
Description
This PR aims to include a new utility function to get supported chains from the Security Alerts API when enabled.
Related Repository
Refer to the Security Alerts API repository for more details.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1870
Manual testing steps
Test blockaid regression
add the envs
security-alerts
and find the call to the API service.Existing PPOM logic should function as before, even with the above environment variables added, due to the fallback to the controller in the event of an error.
Screenshots/Recordings
Screencast.from.19-07-2024.14.42.48.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist