Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): pin action versions for external docker/ actions #10491

Merged
merged 1 commit into from
Jul 31, 2024
Merged

chore(ci): pin action versions for external docker/ actions #10491

merged 1 commit into from
Jul 31, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 31, 2024 •
edited
Loading

Description

Pinning of third-party GHA actions.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review July 31, 2024 02:56
@legobeat legobeat requested a review from a team as a code owner July 31, 2024 02:56
@legobeat legobeat added team-security tests Test related issues area-testSuite No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. labels Jul 31, 2024
sethkfman
sethkfman approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman removed the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jul 31, 2024
@sethkfman sethkfman merged commit 95fd5df into MetaMask:main Jul 31, 2024
47 of 53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@legobeat legobeat deleted the ci-pin-docker-actions branch July 31, 2024 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
area-testSuite No QA Needed Apply this label when your PR does not need any QA effort. team-security tests Test related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @sethkfman