Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pod install on linux #10452

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 28, 2024

Treats xcode as not installed if not available.
Fixes yarn setup --build-ios error on Linux.

This patch will not be needed from react-native 0.74 and later: reactwg/react-native-releases#296

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review July 28, 2024 21:43
@legobeat legobeat requested a review from a team as a code owner July 28, 2024 21:43
Cal-L
Cal-L previously approved these changes Jul 30, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leotm
leotm previously approved these changes Jul 31, 2024
treats xcode as not installed if not available
@legobeat legobeat force-pushed the fix-pod-install-linux branch from 48957c7 to b5be8a5 Compare July 31, 2024 11:50
@leotm leotm dismissed stale reviews from Cal-L and themself via 9b279b5 July 31, 2024 12:29
@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 31, 2024
sethkfman pushed a commit that referenced this pull request Jul 31, 2024
## **Description**

Pinning of third-party GHA actions.

## **Related issues**
- #10452

## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@sethkfman sethkfman merged commit 7e54c9c into MetaMask:main Jul 31, 2024
32 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@legobeat legobeat deleted the fix-pod-install-linux branch July 31, 2024 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants