Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove installation of redundant detox-cli in bitrise #10449

Merged
merged 8 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ workflows:
prep_environment:
steps:
- script@1:
title: node, yarn, corepack installation
inputs:
- content: |-
#!/usr/bin/env bash
Expand All @@ -258,7 +259,7 @@ workflows:

set -e

# Install and enable NVM
# Add and enable NVM
wget -O install-nvm.sh "https://raw.githubusercontent.com/nvm-sh/nvm/v${NVM_VERSION}/install.sh"
echo "${NVM_SHA256SUM} install-nvm.sh" > install-nvm.sh.SHA256SUM
sha256sum -c install-nvm.sh.SHA256SUM
Expand All @@ -276,15 +277,16 @@ workflows:
npm i -g "corepack@$COREPACK_VERSION"
echo "Corepack enabling $YARN_VERSION"
corepack enable
title: Install node, yarn and corepack
install_detox:
install_applesimutils:
steps:
- script@1:
title: applesimutils installation
inputs:
- content: |-
#!/usr/bin/env bash
scripts/detox-setup.sh
title: Install Detox Dependencies
echo "Now installing applesimutils..."
brew tap wix/brew
brew install applesimutils

# Notifications utility workflows
# Provides values for commit or branch message and path depending on commit env setup initialised or not
Expand Down Expand Up @@ -569,7 +571,6 @@ workflows:
android_e2e_build:
before_run:
- code_setup
- install_detox
legobeat marked this conversation as resolved.
Show resolved Hide resolved
- set_commit_hash
after_run:
- notify_failure
Expand Down Expand Up @@ -645,7 +646,6 @@ workflows:
before_run:
- setup
- prep_environment
- install_detox
after_run:
- notify_failure
steps:
Expand Down Expand Up @@ -737,8 +737,8 @@ workflows:
ios_api_specs:
before_run:
- setup
- install_applesimutils
- prep_environment
- install_detox
after_run:
- notify_failure
steps:
Expand Down Expand Up @@ -803,8 +803,8 @@ workflows:
title: Deploy test report files
ios_e2e_build:
before_run:
- install_applesimutils
- code_setup
- install_detox
- set_commit_hash
after_run:
- notify_failure
Expand Down Expand Up @@ -833,7 +833,7 @@ workflows:
inputs:
- content: |-
#!/usr/bin/env bash
brew install ccache with HOMEBREW_NO_DEPENDENTS_CHECK=1
HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK=1 brew install ccache
ln -s $(which ccache) /usr/local/bin/gcc
ln -s $(which ccache) /usr/local/bin/g++
ln -s $(which ccache) /usr/local/bin/cc
Expand Down Expand Up @@ -890,8 +890,8 @@ workflows:
ios_e2e_test:
before_run:
- setup
- install_applesimutils
- prep_environment
- install_detox
after_run:
- notify_failure
steps:
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"format": "prettier '**/*.{js,ts,tsx,json,feature}' --write",
"setup": "yarn clean && node scripts/setup.mjs",
"setup:e2e": "cd wdio && yarn install",
"setup:detox-e2e": "./scripts/detox-setup.sh",
legobeat marked this conversation as resolved.
Show resolved Hide resolved
"start:ios": "./scripts/build.sh ios debug",
"start:ios:qa": "./scripts/build.sh ios qaDebug",
"start:ios:e2e": "./scripts/build.sh ios debugE2E",
Expand Down Expand Up @@ -441,7 +440,7 @@
"browserstack-local": "^1.5.1",
"chromedriver": "^123.0.1",
"depcheck": "^1.4.7",
"detox": "20.23.1",
"detox": "20.27.2",
"dotenv": "^16.0.3",
"enzyme": "3.9.0",
"enzyme-adapter-react-16": "1.10.0",
Expand Down
12 changes: 0 additions & 12 deletions scripts/detox-setup.sh

This file was deleted.

14 changes: 10 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -15739,17 +15739,23 @@ detect-node@^2.0.4:
resolved "https://registry.yarnpkg.com/detect-node/-/detect-node-2.1.0.tgz#c9c70775a49c3d03bc2c06d9a73be550f978f8b1"
integrity sha512-T0NIuQpnTvFDATNuHN5roPwSBG83rFsuO+MXXH9/3N1eFbn4wcPjttvjMLEPWJ0RGUYgQE7cGgS3tNxbqCGM7g==

detox@20.23.1:
version "20.23.1"
resolved "https://registry.yarnpkg.com/detox/-/detox-20.23.1.tgz#57970c4bd7bdfc35f395c98106bbfb4be1c65150"
integrity sha512-K3UWCatYokzQStXxBTqrWzX0pLUBUCngNY3jGL61q6b1UH37vXPziGtOjWmKZ9zDQlxWC/HT7QWSiJqHn81DwA==
detox-copilot@^0.0.9:
version "0.0.9"
resolved "https://registry.yarnpkg.com/detox-copilot/-/detox-copilot-0.0.9.tgz#cc1ddd869868987d3527c93d2604b5d66f3c8466"
integrity sha512-Wk2fuisD8EH+349b0ysNWvZ7UEsThAChbYFlLqOR1jWkDaonEvgf6IOUlmxjvyTl9ENtl8ckd1U7k94yCBYwqw==

detox@20.27.2:
version "20.27.2"
resolved "https://registry.yarnpkg.com/detox/-/detox-20.27.2.tgz#aa22a146b968b6e5f78687557081cf32d26ca066"
integrity sha512-cC6S40v7ix+uA5jYzG8eazSs7YtOWgc2aCwWLZIIzfE5Kvo0gfHgtqeRhrYWCMZaj/irKKs39h2B070oNQOIrA==
dependencies:
ajv "^8.6.3"
bunyan "^1.8.12"
bunyan-debug-stream "^3.1.0"
caf "^15.0.1"
chalk "^4.0.0"
child-process-promise "^2.2.0"
detox-copilot "^0.0.9"
execa "^5.1.1"
find-up "^5.0.0"
fs-extra "^11.0.0"
Expand Down
Loading