chore: remove installation of redundant detox-cli in bitrise

[legobeat]

The package detox-cli is just acting as a shim for detox and isn't actually needed: https://github.com/wix/Detox/blob/master/detox-cli/cli.js

• ci: No global installation of detox-cli package
• Remove redundant setup:detox-e2e package script
• ci: Skip applesimutils installation for bitrise android e2e
• ci: Properly pass HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK to brew
• devDeps: bump detox to latest

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/detox-copilot@0.0.9	eval, filesystem	0	55.8 kB	asafkorem
npm/detox@20.27.2	environment, eval, filesystem, network, shell, unsafe	0	13.2 MB	wix.mobile

🚮 Removed packages: npm/detox@20.23.1

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[legobeat]

@SocketSecurity ignore npm/detox-cli@20.0.0

[cortisiko]

@legobeat, I recently merged a PR that removed detox from the setup script. Having detox cli as a dev dependency makes sense. Perhaps resolve the conflict with main on this PR and we can aim to get this merge

[legobeat]

@cortisiko Rebased.

Might I ask, why was the approach (installing it globally in bitrise, and leaving it as exercise for the dev elsewhere) in #10553 preferred over this PR (install it through devDependencies in every environment, like any other devdep)?

[cortisiko]

@cortisiko Rebased.

Might I ask, why was the approach (installing it globally in bitrise, and leaving it as exercise for the dev elsewhere) in #10553 preferred over this PR (install it through devDependencies in every environment, like any other devdep)?

@legobeat ah, hmmm, so I wasn't aware you had opened this PR, so it wasn't a matter of preference. Installing Detox as a dev dependency makes sense to me. Before merging this PR, Can we kick off an e2e test build on bitrise for good measure?

Will need to get Bitrise to pass

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.80%. Comparing base (b9dbf4d) to head (ecf8b1a).
Report is 56 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10449      +/-   ##
==========================================
- Coverage   55.84%   53.80%   -2.05%     
==========================================
  Files        1594     1639      +45     
  Lines       37855    38180     +325     
  Branches     4545     4627      +82     
==========================================
- Hits        21142    20541     -601     
- Misses      16214    16226      +12     
- Partials      499     1413     +914     

Flag	Coverage Δ
	53.80% <ø> (-2.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[legobeat]

@Cal-L: Passing bitrise run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d58b4ec-72d9-4e3e-b1e9-020db0639848

detox-cli is just a shim for the detox binary provided by package depenedncy detox so it can actually be fully removed.

[cortisiko]

LGTM!