chore: selectors confirmations dir #10397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommasini
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
17 tasks
tommasini
added
Run Smoke E2E
|
tommasini
added
Run Smoke E2E
|
matthewwalsh0
previously approved these changes
Jul 25, 2024
|
Let's only merge this PR once the Transaction Controller to v35 is merged! |
OGPoyraz
previously approved these changes
Jul 25, 2024
tommasini
dismissed stale reviews from MarioAslau, OGPoyraz, and matthewwalsh0
via
3a57e13
tommasini
added
Run Smoke E2E
|
## **Description** Use existing selectors on accounts and snaps directories ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
MarioAslau
approved these changes
Jul 30, 2024
tommasini
added
Run Smoke E2E
|
omridan159
approved these changes
Jul 31, 2024
tommasini
added
Run Smoke E2E
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.29.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add selectors to confirmations directory
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-07-25.at.11.33.06.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist