chore: Abstract controller selectors in confirmations dir

[Cal-L]

What is this about?

This task is a prerequisite for abstracting controller selectors in preparation for optimizing selectors (memoization). This task focuses on files in the confirmations dir.

Scenario

No response

Design

No response

Technical Details

Abstract selectors for the following files. If the selector doesn't exist yet, we will need to create them in the selectors dir

• app/components/Views/confirmations/Approval/index.js
  705,23: transactions: state.engine.backgroundState.TransactionController.transactions,

• app/components/Views/confirmations/ApproveView/Approve/index.js
  920,23: transactions: state.engine.backgroundState.TransactionController.transactions,
  930,22: addressBook: state.engine.backgroundState.AddressBookController.addressBook,

• app/components/Views/confirmations/components/ApproveTransactionReview/AddNickname/index.tsx
  270,22: addressBook: state.engine.backgroundState.AddressBookController.addressBook,

• app/components/Views/confirmations/components/EditGasFeeLegacyUpdate/index.tsx
  90,13: state.engine.backgroundState.GasFeeController.gasEstimateType,

• app/components/Views/confirmations/Send/index.js
  784,22: addressBook: state.engine.backgroundState.AddressBookController.addressBook,

• app/components/Views/confirmations/SendFlow/AddressList/AddressList.tsx
  58,13: state.engine.backgroundState.AddressBookController.addressBook,

• app/components/Views/confirmations/SendFlow/Confirm/components/CustomGasModal/CustomGasModal.tsx
  55,13: state.engine.backgroundState.GasFeeController.gasEstimateType,

• app/components/Views/confirmations/SendFlow/SendTo/index.js
  670,22: addressBook: state.engine.backgroundState.AddressBookController.addressBook,

Threat Modeling Framework

No response

Acceptance Criteria

• App behavior remains the same
• Spot check the flows where changes were made to confirm consistent behavior

Stakeholder review needed before the work gets merged

• Engineering (needed in most cases)
• Design
• Product
• QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• Security
• Legal
• Marketing
• Management (please specify)
• Other (please specify)

References

No response