Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction cancel speed up modal should disappear after transaction is confirmed #10362

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 22, 2024

Description

transaction cancel speed up modal should disappear after transaction is confirmed

Related issues

Fixes: #7387

Manual testing steps

  1. Create s send transaction
  2. Choose to speedup transaction
  3. Speedup modal should disappear once transaction is confirmed

Screenshots/Recordings

Screen.Recording.2024-07-22.at.7.12.03.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jul 22, 2024
@jpuri jpuri requested a review from a team as a code owner July 22, 2024 13:43
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 22, 2024
Copy link
Contributor

github-actions bot commented Jul 22, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 58afcb9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4c908ba9-0ab5-4838-a837-edc9f87dfbda

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@matthewwalsh0 matthewwalsh0 changed the title fix: transaction cancel sppedup modal should disappear after transaction is confirmed fix: transaction cancel speed up modal should disappear after transaction is confirmed Jul 22, 2024
@jpuri jpuri merged commit c916912 into main Jul 22, 2024
47 of 48 checks passed
@jpuri jpuri deleted the spped_cancel_tx_fix branch July 22, 2024 23:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Speed UP/Cancel modal not closed after transaction is confirmed
4 participants