Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Speed UP/Cancel modal not closed after transaction is confirmed #7387

Closed
seaona opened this issue Oct 4, 2023 · 4 comments · Fixed by #10362
Closed

[Bug]: Speed UP/Cancel modal not closed after transaction is confirmed #7387

seaona opened this issue Oct 4, 2023 · 4 comments · Fixed by #10362
Assignees
Labels
needs-estimate release-7.29.0 Issue or pull request that will be included in release 7.29.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Oct 4, 2023

Describe the bug

Problem: whenever I have send a transaction (before being confirmed) I can click on Speed Up / Cancel the transaction. Whenever the modal is open, it remains open even after the initial transaction has been confirmed.

Expected behavior

Once the initial transaction has been confirmed, the modal for Speeding up / Cancel that transaction should be closed, as it's not possible to speed up or cancel that transaction anymore.

This is the behaviour we observe on extension cc @bschorchit

Screenshots

speed-up-open.mp4

Extension:

extension-speedup.mp4

Steps to reproduce

  1. Perform a transaction
  2. Before being confirmed, click speed up / cancel
  3. Wait with the modal open
  4. Tx is confirmed
  5. Try to Confirm the Spped up or cancel
  6. See error
  7. Try again (see you can try infinitely)

Error messages or log output

No response

Version

7.7.0 production (possible an old issue)

Build type

None

Device

Pixel

Operating system

Android

Additional context

No response

Severity

No response

@seaona seaona added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Oct 4, 2023
@anaamolnar anaamolnar added the Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking label Oct 5, 2023
@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Nov 29, 2023
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 19, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Feb 27, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 5, 2024
@seaona
Copy link
Contributor Author

seaona commented May 14, 2024

This issue is still present

@seaona seaona reopened this May 14, 2024
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by severity May 14, 2024
@seaona seaona removed the stale Issues that have not had activity in the last 90 days label May 14, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team May 14, 2024
@bschorchit bschorchit added team-confirmations Push issues to confirmations team and removed team-confirmations-planning (only for internal use within Confirmations team) labels Jun 17, 2024
@sleepytanya
Copy link
Contributor

sleepytanya commented Jul 19, 2024

Present in v7.27.0:

iOS:

cancel.mov

Android (user spammed with the messages with no immediate way to pause or stop them):

cancelAndroid.mov

@jpuri jpuri self-assigned this Jul 22, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jul 22, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jul 22, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-estimate release-7.29.0 Issue or pull request that will be included in release 7.29.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Archived in project
7 participants