Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable webview debugging for all builds but prod #10285

Merged
merged 7 commits into from
Aug 21, 2024
Merged

chore: enable webview debugging for all builds but prod #10285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6a4f89
enable webview debugging for all builds but prod
jpcloureiro Jul 11, 2024
ec8a3ba
Merge branch 'main' into chore/enable-webview-debugger
joaoloureirop Jul 26, 2024
13c46af
Merge branch 'main' into chore/enable-webview-debugger
joaoloureirop Aug 1, 2024
34dde9f
use METAMASK_ENVIRONMENT env var to decide when to enable
joaoloureirop Aug 1, 2024
503e1dd
Merge branch 'main' into chore/enable-webview-debugger
joaoloureirop Aug 13, 2024
e8b2d15
docs: update webview debugging instructions
joaoloureirop Aug 13, 2024
5aed163
Merge branch 'main' into chore/enable-webview-debugger
Daniel-Cross Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/components/Views/BrowserTab/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ import { useMetrics } from '../../../components/hooks/useMetrics';
import { trackDappViewedEvent } from '../../../util/metrics';
import trackErrorAsAnalytics from '../../../util/metrics/TrackError/trackErrorAsAnalytics';
import { selectPermissionControllerState } from '../../../selectors/snaps/permissionController';
import { isTest } from '../../../util/test/utils.js';

const { HOMEPAGE_URL, NOTIFICATION_NAMES } = AppConstants;
const HOMEPAGE_HOST = new URL(HOMEPAGE_URL)?.hostname;
Expand Down Expand Up @@ -1530,6 +1531,7 @@ export const BrowserTab = (props) => {
testID={BrowserViewSelectorsIDs.BROWSER_WEBVIEW_ID}
applicationNameForUserAgent={'WebView MetaMaskMobile'}
onFileDownload={handleOnFileDownload}
webviewDebuggingEnabled={isTest}
/>
{ipfsBannerVisible && renderIpfsBanner()}
</>
Expand Down
1 change: 1 addition & 0 deletions docs/readme/debugging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Android
iOS

- Run the app in debug mode (for example, in a simulator)
- Make sure the value of `webviewDebuggingEnabled` prop on the Webview component is `true`
- Open Safari on your desktop
- Go to the menu Develop -> [Your device] -> [Website]

Expand Down
Loading