Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable webview debugging for all builds but prod #10285

Merged
merged 7 commits into from
Aug 21, 2024
Merged

chore: enable webview debugging for all builds but prod #10285

merged 7 commits into from
Aug 21, 2024

Conversation

jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Jul 11, 2024 •
edited by joaoloureirop
Loading

Description

Enable react-native-webview debugging in non-production builds

Follow docs on how to use the webview debugger

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1858

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@joaoloureirop joaoloureirop self-assigned this Jul 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ec8a3ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1e9e472-1808-400a-bb21-7f82c60cc7b6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@joaoloureirop joaoloureirop marked this pull request as ready for review August 13, 2024 13:54
@joaoloureirop joaoloureirop requested a review from a team as a code owner August 13, 2024 13:54
@joaoloureirop joaoloureirop changed the title enable webview debugging for all builds but prod chore: enable webview debugging for all builds but prod Aug 13, 2024
@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 13, 2024
@joaoloureirop joaoloureirop requested review from joaoloureirop and removed request for joaoloureirop August 13, 2024 14:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e8b2d15
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4998b2b8-6221-4669-b400-77a827ca399d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 13, 2024
NicolasMassart
NicolasMassart approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Daniel-Cross
Daniel-Cross approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joaoloureirop joaoloureirop added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5aed163
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/81843c7f-1b29-44b0-9e95-062031414239

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@joaoloureirop joaoloureirop merged commit 37e3897 into main Aug 21, 2024
39 checks passed
@joaoloureirop joaoloureirop deleted the chore/enable-webview-debugger branch August 21, 2024 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@metamaskbot metamaskbot added the release-7.30.0 Issue or pull request that will be included in release 7.30.0 label Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Daniel-Cross Daniel-Cross Daniel-Cross approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

@joaoloureirop joaoloureirop

Labels
external-contributor No QA Needed Apply this label when your PR does not need any QA effort. release-7.30.0 Issue or pull request that will be included in release 7.30.0 RNWebView Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jpcloureiro @NicolasMassart @Daniel-Cross @metamaskbot @joaoloureirop