[Design quality]: Update the mobile header to the design system header - Navbar Title & Receive Flow #12768
Assignees
Labels
area-design
Design bug (previously known as papercuts - ask Hilary for more detail)
regression-prod-11.16.15
Regression bug that was found in production in release 11.16.15
release-7.39.0
Issue or pull request that will be included in release 7.39.0
Sev3-low
A possible confusion or deception that is only hypothetical & has no known instances in the wild
team-design-system
All issues relating to design system in Mobile
type-bug
Something isn't working
Comments
brianacnguyen
added
area-design
brianacnguyen
changed the title
brianacnguyen
changed the title
This was referenced Dec 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 20, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - This PR updates the navbar title to remove the green dot - Also updated the navbar title in Receive flow <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #12768 ## **Manual testing steps** 1. Go to wallet 2. Click on asset 3. Observe change in header 4. Go to receive 5. Observe change in header ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/84d7e1c0-a9a9-4c26-9584-6d83cd1614bd   <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.39.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In mobile, the header we have is deprecated across many pages. Updating all headers to the version we have in our design system creates a consistent look and feel.
Expected behavior
Headers for all pages use the DS version, namely:
Screenshots/Recordings
Figma link
Steps to reproduce
Error messages or log output
No response
Detection stage
In production (default)
Version
11.16.15
Build type
None
Device
Samsung
Operating system
Android
Additional context
Ping @amandaye0h for context
Severity
No response
The text was updated successfully, but these errors were encountered: