Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design quality]: Update the mobile header to the design system header #11050

Closed
amandaye0h opened this issue Sep 4, 2024 · 1 comment
Closed

[Design quality]: Update the mobile header to the design system header #11050

amandaye0h opened this issue Sep 4, 2024 · 1 comment
Assignees
@brianacnguyen @gambinish
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.16.15 Regression bug that was found in production in release 11.16.15 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-design-system All issues relating to design system in Mobile type-bug Something isn't working

Comments

@amandaye0h
Copy link

amandaye0h commented Sep 4, 2024 •
edited
Loading

Describe the bug

In mobile, the header we have is deprecated across many pages. Updating all headers to the version we have in our design system creates a consistent look and feel.

Expected behavior

Headers for all pages use the DS version, namely:

  • Token Details
  • Transactions
  • Buy
  • Sell
  • Swap
  • Send
  • Receive (new receive flow, ticket #10061 )

Screenshots/Recordings

Screenshot 2024-10-18 at 12 56 18 AM

Figma link

Steps to reproduce

  1. Open MetaMask
  2. Click on Token details

Error messages or log output

No response

Detection stage

In production (default)

Version

11.16.15

Build type

None

Device

Samsung

Operating system

Android

Additional context

Ping @amandaye0h for context

Severity

No response
@amandaye0h amandaye0h added the type-bug Something isn't working label Sep 4, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 4, 2024
@amandaye0h amandaye0h added the area-design Design bug (previously known as papercuts - ask Hilary for more detail) label Sep 4, 2024
@metamaskbot metamaskbot added the regression-prod-11.16.15 Regression bug that was found in production in release 11.16.15 label Sep 4, 2024
@brianacnguyen brianacnguyen self-assigned this Sep 4, 2024
@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system in Mobile label Sep 5, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 19, 2024
@Nick-Son Nick-Son added the Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild label Oct 11, 2024
@hesterbruikman hesterbruikman mentioned this issue Dec 3, 2024
Open
@brianacnguyen
Copy link
Contributor

This issue has been broken down into multiple issues
#11854
#12768
#12769
#12770
#12771
#12772

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 18, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianacnguyen brianacnguyen

@gambinish gambinish

Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) regression-prod-11.16.15 Regression bug that was found in production in release 11.16.15 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-design-system All issues relating to design system in Mobile type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Nick-Son @brianacnguyen @gambinish @metamaskbot @amandaye0h