Skip to content

Commit

Permalink
fix: total balance render (#12226)
Browse files Browse the repository at this point in the history
## **Description**

Cherry-picks #12205

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
sahar-fehri authored Nov 7, 2024
1 parent 2f6c695 commit 226e02b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions app/components/Views/Wallet/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ import { ButtonVariants } from '../../../component-library/components/Buttons/Bu
import { useListNotifications } from '../../../util/notifications/hooks/useNotifications';
import { PortfolioBalance } from '../../UI/Tokens/TokenList/PortfolioBalance';
import { isObject } from 'lodash';
import { selectContractBalances } from '../../../selectors/tokenBalancesController';

const createStyles = ({ colors, typography }: Theme) =>
StyleSheet.create({
Expand Down Expand Up @@ -189,6 +190,7 @@ const Wallet = ({
* ETH to current currency conversion rate
*/
const conversionRate = useSelector(selectConversionRate);
const contractBalances = useSelector(selectContractBalances);
/**
* Currency code of the currently-active currency
*/
Expand Down Expand Up @@ -625,6 +627,7 @@ const Wallet = ({
</>
</View>
);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [
tokens,
accountBalanceByChainId,
Expand All @@ -640,6 +643,7 @@ const Wallet = ({
ticker,
conversionRate,
currentCurrency,
contractBalances,
]);
const renderLoader = useCallback(
() => (
Expand Down

0 comments on commit 226e02b

Please sign in to comment.