fix: add contractBalances as dependency

[sahar-fehri]

Description

This PR forces UI to rerender when contractBalances change in state.

When a user switches from account A to account B; the value of contractBalances would still have the state values from accountA;
If account A and accountB have some tokens in common (exp both hold USDC) you would see the total = native fiat value + USDC value;
Also; When a user switches accounts, the tokensStateChange subscription is fired; except that by the time it got to update the contractBalances in state; the UI has already rendered the total fiat value;
The reason why after a while, it would update to the correct total value; is because the conversionRate in state would change forcing the UI to re-render the component;
My fix here is adding contractBalances as a dependency which will force the array to rerender once contractBalances in state are updated;

Related issues

Fixes:

Manual testing steps

1. Import two accounts with native and ERC20 balances
2. Switch between accounts;
3. You should see the correct total balance in fiat

Screenshots/Recordings

Before

Screen.Recording.2024-11-06.at.15.40.04.mov

After

Screen.Recording.2024-11-06.at.15.43.41.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e0489a5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4cb4b9c6-859b-426b-b8fa-ea3516c11e17

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sethkfman]

LGTM