fix: Update signature-controller package to latest
#28916
Closed
+53
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/signature-controller@23.0.0 |
digiwand
approved these changes
Dec 4, 2024
OGPoyraz
added a commit
to MetaMask/core
that referenced
this pull request
Dec 5, 2024
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR aims to update two packages - `jsonschema@1.4.1` New version allows us to use `if` `else` clauses in the schemas properly. By doing local tests previous versions were just letting it pass. - `eth-sig-util@8.1.0` Extends `Permit` signature schema into exported `TYPED_MESSAGE_SCHEMA`, controller already importing and validating with that schema hence no code change is needed. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> * Fixes: MetaMask/MetaMask-planning#3582 * Extension PR: MetaMask/metamask-extension#28916 ## Recordings https://github.com/user-attachments/assets/ac998fea-930d-4069-ae62-1f6aefff1465 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/signature-controller` - **Fixed**: Extends missing `Permit` signature schema validation ## Checklist - [X] I've updated the test suite for new or updated code as appropriate - [X] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [X] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [X] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
signature-controllerandeth-sig-utilto latest versions.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3582
Manual testing steps
To test this you need to be able to adjust
signTypedV4parameters in test-dapp.Screenshots/Recordings
permit.schema.validation.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist