Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update jsonschema version & eth-sig-util #4998

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Nov 28, 2024

Explanation

This PR aims to update two packages

  • jsonschema@1.4.1
    New version allows us to use if else clauses in the schemas properly. By doing local tests previous versions were just letting it pass.

  • eth-sig-util@8.1.0
    Extends Permit signature schema into exported TYPED_MESSAGE_SCHEMA, controller already importing and validating with that schema hence no code change is needed.

References

Recordings

permit.schema.validation.mov

Changelog

@metamask/signature-controller

  • Fixed: Extends missing Permit signature schema validation

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@OGPoyraz OGPoyraz requested review from a team as code owners November 28, 2024 10:55
@OGPoyraz OGPoyraz marked this pull request as draft November 28, 2024 10:56
@OGPoyraz
Copy link
Member Author

OGPoyraz commented Dec 4, 2024

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "20.0.1-preview-175f4f5d",
  "@metamask-previews/address-book-controller": "6.0.2-preview-175f4f5d",
  "@metamask-previews/announcement-controller": "7.0.2-preview-175f4f5d",
  "@metamask-previews/approval-controller": "7.1.1-preview-175f4f5d",
  "@metamask-previews/assets-controllers": "45.1.1-preview-175f4f5d",
  "@metamask-previews/base-controller": "7.0.2-preview-175f4f5d",
  "@metamask-previews/build-utils": "3.0.2-preview-175f4f5d",
  "@metamask-previews/chain-controller": "0.2.1-preview-175f4f5d",
  "@metamask-previews/composable-controller": "9.0.1-preview-175f4f5d",
  "@metamask-previews/controller-utils": "11.4.4-preview-175f4f5d",
  "@metamask-previews/ens-controller": "15.0.1-preview-175f4f5d",
  "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-175f4f5d",
  "@metamask-previews/gas-fee-controller": "22.0.2-preview-175f4f5d",
  "@metamask-previews/json-rpc-engine": "10.0.1-preview-175f4f5d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-175f4f5d",
  "@metamask-previews/keyring-controller": "19.0.1-preview-175f4f5d",
  "@metamask-previews/logging-controller": "6.0.3-preview-175f4f5d",
  "@metamask-previews/message-manager": "11.0.2-preview-175f4f5d",
  "@metamask-previews/multichain": "1.1.1-preview-175f4f5d",
  "@metamask-previews/name-controller": "8.0.2-preview-175f4f5d",
  "@metamask-previews/network-controller": "22.1.0-preview-175f4f5d",
  "@metamask-previews/notification-services-controller": "0.15.0-preview-175f4f5d",
  "@metamask-previews/permission-controller": "11.0.4-preview-175f4f5d",
  "@metamask-previews/permission-log-controller": "3.0.2-preview-175f4f5d",
  "@metamask-previews/phishing-controller": "12.3.1-preview-175f4f5d",
  "@metamask-previews/polling-controller": "12.0.2-preview-175f4f5d",
  "@metamask-previews/preferences-controller": "15.0.1-preview-175f4f5d",
  "@metamask-previews/profile-sync-controller": "3.0.0-preview-175f4f5d",
  "@metamask-previews/queued-request-controller": "8.0.1-preview-175f4f5d",
  "@metamask-previews/rate-limit-controller": "6.0.2-preview-175f4f5d",
  "@metamask-previews/remote-feature-flag-controller": "1.1.0-preview-175f4f5d",
  "@metamask-previews/selected-network-controller": "20.0.1-preview-175f4f5d",
  "@metamask-previews/signature-controller": "23.0.1-preview-175f4f5d",
  "@metamask-previews/transaction-controller": "41.1.0-preview-175f4f5d",
  "@metamask-previews/user-operation-controller": "20.0.1-preview-175f4f5d"
}

@OGPoyraz OGPoyraz marked this pull request as ready for review December 4, 2024 09:20
@OGPoyraz OGPoyraz requested a review from a team as a code owner December 4, 2024 09:20
@OGPoyraz OGPoyraz enabled auto-merge (squash) December 4, 2024 13:09
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good regarding those files:

packages/keyring-controller/package.json

@OGPoyraz OGPoyraz merged commit 1511e04 into main Dec 5, 2024
120 checks passed
@OGPoyraz OGPoyraz deleted the fix/permit-signature-schema branch December 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants