-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update jsonschema
version & eth-sig-util
#4998
Conversation
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good regarding those files:
packages/keyring-controller/package.json
Explanation
This PR aims to update two packages
jsonschema@1.4.1
New version allows us to use
if
else
clauses in the schemas properly. By doing local tests previous versions were just letting it pass.eth-sig-util@8.1.0
Extends
Permit
signature schema into exportedTYPED_MESSAGE_SCHEMA
, controller already importing and validating with that schema hence no code change is needed.References
signature-controller
package to latest metamask-extension#28916Recordings
permit.schema.validation.mov
Changelog
@metamask/signature-controller
Permit
signature schema validationChecklist