fix: selected network when there are two with the same chain id. #25805

montelaidev · 2024-07-12T14:53:20Z

Description

This PR fixes the issue when there are two networks with the same chain id and the default network is selected.

Related issues

Fixes: #25763

Manual testing steps

Add a custom network with the chain id of 1
Switch to this network
See that it is selected.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-12T14:53:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-15T15:02:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (8574f94) to head (46b22c1).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25805      +/-   ##
===========================================
+ Coverage    69.69%   69.69%   +0.01%     
===========================================
  Files         1401     1401              
  Lines        49577    49590      +13     
  Branches     13701    13707       +6     
===========================================
+ Hits         34548    34561      +13     
  Misses       15029    15029

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-15T15:11:43Z

Builds ready [c9bc7c6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (219 ± 215 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	189	103	27	13
		domContentLoaded	10	43	25	9	4
		load	45	1596	219	448	215
		domInteractive	10	43	25	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 96 Bytes (0.00%)
common: 431 Bytes (0.01%)

ui/selectors/multichain.ts

ui/components/multichain/app-header/app-header.test.js

ui/selectors/multichain.test.ts

ui/selectors/multichain.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

georgewrmarshall · 2024-07-18T15:29:47Z

Hey @montelaidev, did you specifically ask for @MetaMask/design-system-engineers review for this PR? Trying to figure out why we got tagged as code owners here. Happy for our team to review if so

…work-picker

montelaidev · 2024-07-19T03:43:02Z

Hey @montelaidev, did you specifically ask for @MetaMask/design-system-engineers review for this PR? Trying to figure out why we got tagged as code owners here. Happy for our team to review if so

Hey @georgewrmarshall, there was a change in a design system component that was reverted. I think its ok now, we can remove @MetaMask/design-system-engineers from the reviewers. Thanks for checking in!

metamaskbot · 2024-07-19T05:08:16Z

Builds ready [b741527]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (325 ± 281 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	166	114	22	11
		domContentLoaded	9	68	30	17	8
		load	41	1797	325	586	281
		domInteractive	9	68	30	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 96 Bytes (0.00%)
common: 418 Bytes (0.01%)

ui/components/multichain/app-header/app-header.test.js

ui/selectors/multichain.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

metamaskbot · 2024-07-19T13:01:22Z

Builds ready [cd9e0b7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (157 ± 168 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	151	106	20	10
		domContentLoaded	10	68	32	15	7
		load	45	1676	157	349	168
		domInteractive	10	68	32	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 96 Bytes (0.00%)
common: 434 Bytes (0.01%)

ui/selectors/multichain.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

darkwing · 2024-07-19T14:11:42Z

Do we know how/when this regressed? Please test re: v12, 12.1, etc, because this is problematic

montelaidev · 2024-07-19T14:57:43Z

Do we know how/when this regressed? Please test re: v12, 12.1, etc, because this is problematic

It looks like it is in v12.1 from this 3595052 commit when it started using the multichain networks from this b3c810e commit

metamaskbot · 2024-07-19T14:58:41Z

Builds ready [1e3ee98]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (140 ± 155 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	154	98	23	11
		domContentLoaded	9	70	28	16	8
		load	38	1549	140	324	155
		domInteractive	9	70	28	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 96 Bytes (0.00%)
common: 434 Bytes (0.01%)

sonarcloud · 2024-07-19T15:00:11Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-19T16:07:26Z

Builds ready [46b22c1]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (458 ± 384 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	220	120	38	18
		domContentLoaded	9	66	26	13	6
		load	45	2954	458	799	384
		domInteractive	9	66	26	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 96 Bytes (0.00%)
common: 434 Bytes (0.01%)

montelaidev added 2 commits July 12, 2024 22:53

fix: use providerConfig instead of finding network

0850c44

fix: add tests

427df47

montelaidev requested review from a team as code owners July 12, 2024 14:53

metamaskbot added the team-accounts label Jul 12, 2024

montelaidev added 4 commits July 12, 2024 23:11

fix: revert testid

9b092d2

fix: test

4b8fd26

fix: lint

3bdb6de

fix: name from network configurations

c9bc7c6

ccharly reviewed Jul 16, 2024

View reviewed changes

montelaidev and others added 3 commits July 16, 2024 22:58

Apply suggestions from code review

3be75dd

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

fix: add TODO

651ce47

fix: remove current prefix

9fc6b3e

montelaidev added 2 commits July 19, 2024 11:16

fix:lint

0d38107

Merge remote-tracking branch 'origin/develop' into fix/multichain-net…

b741527

…work-picker

montelaidev removed the request for review from a team July 19, 2024 03:43

ccharly reviewed Jul 19, 2024

View reviewed changes

ui/components/multichain/app-header/app-header.test.js Outdated Show resolved Hide resolved

ui/components/multichain/app-header/app-header.test.js Show resolved Hide resolved

ui/selectors/multichain.ts Outdated Show resolved Hide resolved

montelaidev and others added 2 commits July 19, 2024 18:00

Apply suggestions from code review

b3bd30d

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

refactor: move code into if rpc block

cd9e0b7

ccharly reviewed Jul 19, 2024

View reviewed changes

ui/selectors/multichain.ts Show resolved Hide resolved

ui/selectors/multichain.ts Outdated Show resolved Hide resolved

montelaidev and others added 2 commits July 19, 2024 21:43

Update ui/selectors/multichain.ts

d406922

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

refactor: move comment

67abc58

ccharly approved these changes Jul 19, 2024

View reviewed changes

Merge branch 'develop' into fix/multichain-network-picker

1e3ee98

matthewwalsh0 approved these changes Jul 19, 2024

View reviewed changes

Merge branch 'develop' into fix/multichain-network-picker

46b22c1

montelaidev merged commit 43b8031 into develop Jul 19, 2024
79 checks passed

montelaidev deleted the fix/multichain-network-picker branch July 19, 2024 16:08

github-actions bot locked and limited conversation to collaborators Jul 19, 2024

metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: selected network when there are two with the same chain id. #25805

fix: selected network when there are two with the same chain id. #25805

montelaidev commented Jul 12, 2024 •

edited by AlexJupiter

Loading

github-actions bot commented Jul 12, 2024

codecov bot commented Jul 15, 2024 •

edited

Loading

metamaskbot commented Jul 15, 2024

georgewrmarshall commented Jul 18, 2024 •

edited

Loading

montelaidev commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

darkwing commented Jul 19, 2024

montelaidev commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

sonarcloud bot commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

fix: selected network when there are two with the same chain id. #25805

fix: selected network when there are two with the same chain id. #25805

Conversation

montelaidev commented Jul 12, 2024 • edited by AlexJupiter Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 12, 2024

codecov bot commented Jul 15, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 15, 2024

georgewrmarshall commented Jul 18, 2024 • edited Loading

montelaidev commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

darkwing commented Jul 19, 2024

montelaidev commented Jul 19, 2024

metamaskbot commented Jul 19, 2024

sonarcloud bot commented Jul 19, 2024

Quality Gate passed

metamaskbot commented Jul 19, 2024

montelaidev commented Jul 12, 2024 •

edited by AlexJupiter

Loading

codecov bot commented Jul 15, 2024 •

edited

Loading

georgewrmarshall commented Jul 18, 2024 •

edited

Loading