Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Network name is showing incorrectly after adding Tenderly as custom network #25763

Closed
davibroc opened this issue Jul 11, 2024 · 1 comment · Fixed by #25805
Closed
Assignees
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-accounts type-bug

Comments

@davibroc
Copy link
Contributor

Describe the bug

After adding Tenderly as a custom network the name shown is still Ethereum, most likely because ChainID for both network is 1. While this might seems as a minor issue, in the swap team we often use Tenderly for functionality testing and that allows us to save money. So making sure Tenderly works a custom network is important.

I have investigated the problem and it started with this commit
3595052

The problem doesn't happen with this previous commit
85cf430

Expected behavior

No response

Screenshots/Recordings

Before the changes

Tenderly_name_before.mov

After

Tenderly_Name_after.mov

Steps to reproduce

  1. Add Tenderly as a custom newtork with the following settings
    name: 'Tenderly',
    url: 'https://rpc.tenderly.co/fork/cdbcd795-097d-4624-aa16-680374d89a43',
    chainID: '1',
    symbol: 'ETH'

  2. Notice that the network name still says Ethereum

Error messages or log output

No response

Version

develop

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@davibroc davibroc added type-bug Sev2-normal Normal severity; minor loss of service or inconvenience. team-accounts labels Jul 11, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Aug 15, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.3.0 on issue. Adding release label release-12.3.0 on issue, as issue is linked to PR #25805 which has this release label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-accounts type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants