-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Permit Signature Redesign "Spending cap" copy #25618
feat: update Permit Signature Redesign "Spending cap" copy #25618
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25618 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48173 48173
Branches 13291 13291
========================================
Hits 33527 33527
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
Builds ready [7a95f8d]
Page Load Metrics (344 ± 294 ms)
Bundle size diffs
|
Description
Updates Permit signature redesign copy "Approve spend limit" → "Spending cap"
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2719
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist