Skip to content

Commit

Permalink
feat: update Permit Signature Redesign "Spending cap" copy (#25618)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates Permit signature redesign copy "Approve spend limit" → "Spending
cap"

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25618?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#2719

## **Manual testing steps**

1. Go to test dapp
2. Click on Malicious Permit within the ppom section

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="320"
src="https://github.com/MetaMask/metamask-extension/assets/20778143/c63c615e-4ae3-4cc2-a74d-fe00c9416ece">

### **After**

<img width="320"
src="https://github.com/MetaMask/metamask-extension/assets/20778143/00fc3099-25f9-46ff-bc85-f93b8e36ae86">

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
digiwand authored Jul 2, 2024
1 parent 6557b59 commit c9fcc14
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ exports[`PermitSimulation renders component correctly 1`] = `
<p
class="mm-box mm-text mm-text--body-md-medium mm-box--color-inherit"
>
Approve spend limit
Spending cap
</p>
</div>
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const PermitSimulation: React.FC<{
>
<ConfirmInfoRowText text={t('permitSimulationDetailInfo')} />
</ConfirmInfoRow>
<ConfirmInfoRow label={t('approve')}>
<ConfirmInfoRow label={t('spendingCap')}>
<Box style={{ marginLeft: 'auto' }}>
<Box display={Display.Flex}>
<Box display={Display.Inline} marginInlineEnd={1}>
Expand Down

0 comments on commit c9fcc14

Please sign in to comment.