Refit - Fix some minor and easy things #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5134 +/- ##
=========================================
Coverage 10.53% 10.54%
- Complexity 6041 6046 +5
=========================================
Files 956 956
Lines 134213 134252 +39
Branches 19489 19502 +13
=========================================
+ Hits 14140 14151 +11
- Misses 118722 118747 +25
- Partials 1351 1354 +3 ☔ View full report in Codecov by Sentry. |
WeaverThree
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #5133
Make some quick fixes before I buckle down for more exstensive reftting of the refit system...
Fix some instance checks
Fix checking engine side crits
Fix default refurbish time to something sane
Resolve a few fixme/todos that I now understand
Set time and skill multipliers to CamOps values
Fix an accidental wrong newEntity reference and make a function static that should be.