Refit - Reformat, document, annotate, comment, clarify #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5133 +/- ##
=========================================
Coverage 10.53% 10.53%
- Complexity 6041 6043 +2
=========================================
Files 956 956
Lines 134213 134251 +38
Branches 19489 19502 +13
=========================================
+ Hits 14140 14148 +8
- Misses 118722 118752 +30
Partials 1351 1351 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is me spending a day or two to go through and understand Refit.java, and clean it up as much as I can without (gods willing) changing the logic of it at all. I've added doc comments to nearly everything, I've added a lot of fixmes and some todos marking stuff that needs to be changed or considered. I've renamed a bunch of variables to more descriptive names. I've pulled boolean variables out of some of the worse if statements. I've made a minor change to the way error strings work and added a few ReportingUtilities functions in there.
I'm submitting this as its own PR because having these changes done separately means that the actual changes to function can be evaluated without all the mess of reformatting and cleanup going on around them at the same time.