Implemented Random Mercenary Company Name Generator #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced new enumeration classes for Mercenary company name generation, including `MiddleWordMercenary`, `EndWordCorporate`, and `EndWordMercenary`. Implemented functionality to randomly select names from these enums and added corresponding resource bundles for text values.
Implemented a button in the Campaign Options Pane to generate random company names using the BackgroundsController. The button updates the company name field with a newly generated name, enhancing usability for end-users.
Updated the panInfo's border title to reflect the current campaign's name if the border is an instance of TitledBorder. This enhances the GUI by dynamically displaying the relevant campaign name, improving user experience.
Introduced support for definite articles in random mercenary company names. Updated BackgroundsController to use resources for definite articles and consolidated string construction for name generation.
Enhanced the GUI with a new panel for generating and assigning random mercenary company names. Updated relevant methods and properties to support this functionality.
Added a variety of humorous names to the RandomMercenaryCompanyNameGenerator.properties file. This enhances the variety and entertainment value when generating random mercenary company names.
Added a try-catch block to handle NullPointerException, allowing the method to be tested without needing to mock RandomCallsignGenerator. Returning an empty string if an exception occurs ensures stability during tests.
Introduced the enemyName field to AtBContract to track enemy names. Updated XML read/write methods to include enemyName. Enhanced getEnemyName to ensure enemyName is set and provided a marshallEnemyName method for direct retrieval.
IllianiCBT
added
the
Campaign Options
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4640 +/- ##
============================================
+ Coverage 9.89% 10.65% +0.76%
- Complexity 5678 5702 +24
============================================
Files 945 950 +5
Lines 129805 131271 +1466
Branches 19119 19134 +15
============================================
+ Hits 12845 13988 +1143
- Misses 115745 116059 +314
- Partials 1215 1224 +9 ☔ View full report in Codecov by Sentry. |
Removed the unnecessary parameter from the createGenerateNameButton method. This simplifies the method signature and aligns its usage with other similar button creation methods in the code.
Added code to clear the old enemy name before updating it with the current year's enemy faction name in AtBContract. This ensures that the enemy name is always refreshed correctly during each contract update.
HammerGS
reviewed
Aug 16, 2024
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
HammerGS
reviewed
Aug 16, 2024
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
HammerGS
requested changes
Aug 16, 2024
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
MekHQ/resources/mekhq/resources/RandomMercenaryCompanyNameGenerator.properties
Show resolved
Hide resolved
Expanded the Mercenary Company Name Generator with additional end words. This enhancement provides more variety and flavor for generated mercenary company names.
Integrated numerical name generation with appropriate suffixes for mercenary company names. Refactored the naming logic to include different prefixes and updated the resource bundle with new suffix entries.
It does now! :D |
|
Added numerical name prefixes, allowing us to generate names like "The 22nd Beef Brigade" |
Replaced `marshallEnemyName` with a more robust `generateEnemyName` method to ensure the enemy name is set properly. Added proper handling for missing data and fallback mechanisms to avoid null values.
HammerGS
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things: predominately it implements a random name generator to generate a mercenary company name.
When a player starts a new campaign a random name will be generated in place of the previous 'My Campaign'. Additional company names can be generated via button in Campaign Options. New company names can be generated in active campaigns via the GM Tools dialog. This tech was needed for the upcoming Random Backgrounds Module, as we need to known the origin company name for characters with the 'Mercenary' origin.
Finally, whenever players have a contract against the Mercenary faction mhq will generate a random name for that enemy, instead of using faction name. This tech was needed for a future project currently in pre-development.
There are 6 types of random name: Corporate, Mercenary (Vanity type 1 and 2), Mercenary (Generic), and Pre-Fab (type 1 and 2). If a vanity name is generated mhq will use the name of the current campaign commander, if set, otherwise a random Callsign will be generated.
Examples of the kinds of names generated follows: