Added Academy Validation when Loading Existing Save #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MekHQ will now validate all in-use academies when the campaign XML is parsed. If an academy used in the campaign is not valid, an error is thrown and a corresponding error message is shown.
The PlanetarySystem and Planet import declarations in CampaignXmlParser.java were removed. These were not used in the class and deemed unnecessary, thus helping clean up the code and improve readability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4380 +/- ##
============================================
- Coverage 10.27% 10.27% -0.01%
Complexity 5811 5811
============================================
Files 925 925
Lines 126031 126046 +15
Branches 18627 18633 +6
============================================
Hits 12945 12945
- Misses 111811 111826 +15
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
The check for the existence of an academy in a set was optimized in the CampaignXmlParser class. Additionally, redundant conditionals when adding missing academies to the list were eliminated, and unnecessary repetitive code was simplified for clarity and efficiency.
HammerGS
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MekHQ will now validate all in-use academies when the campaign XML is parsed. If an academy used in the campaign is not valid, an error is thrown and an error message is shown.
Closes #4352