Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPE/RFE] Null pointer exception advancing the day when custom academies are missing #4352

Closed
azhais opened this issue Jul 8, 2024 · 1 comment · Fixed by #4380
Closed
Assignees
Labels
Personnel Personnel-related Issues (RFE) Enhancement Requests for Enhancement, new features or implementations

Comments

@azhais
Copy link

azhais commented Jul 8, 2024

Environment

What version of MekHQ does your issue apply to? 0.49.20
What operating system are you using? Windows
What java version are you using? 17

Description

I switched to a new nightly (this is reproducible in 0.49.20 and that's what the attached save is from) and got a null pointer exception when advancing the day. Looking at the logs, it's because I forgot to copy my custom academies over.

Additionally, if you save the campaign after advancing the day and getting the NPE, put the missing files in place, then reload, the next time you advance the day it will send all students home because their academy was destroyed, even tho they do exist and you can send the students straight back.

It would be nice if MekHQ would check for missing academies the same way it checks for missing custom mechs upon loading the game.

Files

ghost academies30250103.cpnx.gz
mekhq.log
Ghost Academies.zip

@IllianiCBT IllianiCBT self-assigned this Jul 8, 2024
@IllianiCBT IllianiCBT added (RFE) Enhancement Requests for Enhancement, new features or implementations Personnel Personnel-related Issues labels Jul 8, 2024
@IllianiCBT
Copy link
Collaborator

This was a fantastic RFE.

I'm going to go ahead and manually close it, rather than waiting for GitHub to do it automatically, as that makes it easier for me to see what still needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants