Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ability to Order Impossible TN Parts from Acquisitions Dialog. #3975

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Current Implementation

Currently it is not possible to purchase items, from the Parts Acquisition dialog, if that part has a TN >12.

Problem

This forces users to manually order the item from the Purchase Parts dialog. This can be a little awkward, if the part in question has multiple variants (based on weight, for example).

Solution

It is not possible to order Impossible TN missing parts from the Parts Acquisition dialog. In instances where the TN is impossible, this is clearly labeled.

image

Closes #3359

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 10.65%. Comparing base (eaeb54e) to head (34500ee).
Report is 2 commits behind head on master.

Files Patch % Lines
MekHQ/src/mekhq/gui/dialog/AcquisitionsDialog.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3975      +/-   ##
============================================
- Coverage     10.65%   10.65%   -0.01%     
  Complexity     5536     5536              
============================================
  Files           841      841              
  Lines        114411   114422      +11     
  Branches      17209    17210       +1     
============================================
  Hits          12189    12189              
- Misses       100992   101003      +11     
  Partials       1230     1230              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 7747d87 into MegaMek:master Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Allow Ordering of Impossible Parts In Parts Needed Dialogue
4 participants