Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MekHQ part of fix for #4648 #3810

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jan 9, 2024

Mek Mortars and IS BA Tube Artillery are excluded from the MekHQ "Spend XP" SPA menu because they have an AT2 Class of "NONE". By rights this whole AT2 class thing should be torn out, but it seemed more sensible to massage the existing check and add classes to the missing weapons, rather than refactoring a lot of code across all three projects.

This patch restricts the range of AT classes that will be rejected to just the existing Naval / Large Ship weapons.
The full fix also relies on the MegaMek PR here.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (8c9eed9) 10.63% compared to head (d0e4582) 10.63%.
Report is 17 commits behind head on master.

Files Patch % Lines
MekHQ/src/mekhq/gui/dialog/MHQOptionsDialog.java 0.00% 29 Missing ⚠️
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 7 Missing ⚠️
MekHQ/src/mekhq/utilities/MHQXMLUtility.java 0.00% 7 Missing ⚠️
...ekHQ/src/mekhq/campaign/personnel/ranks/Ranks.java 33.33% 3 Missing and 1 partial ⚠️
...Q/src/mekhq/campaign/personnel/SpecialAbility.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3810      +/-   ##
============================================
- Coverage     10.63%   10.63%   -0.01%     
  Complexity     5474     5474              
============================================
  Files           834      834              
  Lines        113768   113811      +43     
  Branches      17196    17198       +2     
============================================
+ Hits          12103    12106       +3     
- Misses       100459   100499      +40     
  Partials       1206     1206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit bef8abb into MegaMek:master Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants