Refactored AutoAwardsController and Fixed Scenario Awards Support
#4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced duplicate campaign parameter assignments with `this.campaign` to clearly indicate class member usage. Added support for scenario awards as a new case in award processing and included logging for better traceability.
IllianiCBT
changed the title
AutoAwardsController and Fixed Scenario Awards SupportAutoAwardsController and Fixed Scenario Awards Support
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4648 +/- ##
============================================
- Coverage 9.90% 9.90% -0.01%
Complexity 5676 5676
============================================
Files 945 945
Lines 129636 129641 +5
Branches 19092 19093 +1
============================================
Hits 12836 12836
- Misses 115583 115588 +5
Partials 1217 1217 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced duplicate campaign parameter assignments with
this.campaignto clearly indicate class member usage. Fixed support for scenario awards as a new case in award processing.