Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario objectives - Part III #1348

Merged
merged 7 commits into from
Nov 20, 2019

Conversation

NickAragua
Copy link
Member

Changes relating to scenario objectives, mostly relevant for template scenarios:

  • Allow a scenario template modifier to add objectives to a scenario (e.g. a hostile facility may become a capture, an extraction, or whatever)
  • Allow a force template to attach to other force templates for the purposes of objectives (e.g. when you add "enemy reinforcements", and there's already an objective to destroy the "primary opfor", the reinforcements become part of that objective as well)
  • The rest of the scenario template files are human-readable
  • Scenario modifiers that are not applicable at the current state of a template scenario are not displayed in the customize scenario UI
  • Corrections to some bugs in objective completion determination and force parameter generation

Copy link
Member

@neoancient neoancient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't interacted much with this feature so I can't say much about the overall logic or the data, but the code changes made sense in their immediate environment and I didn't see any brain farts.

@lgtm-com
Copy link

lgtm-com bot commented Nov 20, 2019

This pull request introduces 1 alert when merging c413c54 into 996d331 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@NickAragua
Copy link
Member Author

Just a quick update to utilize the correct calculation for arrival turn that's actually dependent on the scenario template.

@lgtm-com
Copy link

lgtm-com bot commented Nov 20, 2019

This pull request introduces 1 alert when merging b0e339b into ab2d5ae - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@NickAragua NickAragua merged commit d9ee0c7 into MegaMek:master Nov 20, 2019
@NickAragua NickAragua deleted the scenario_objectives branch November 20, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants