Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if it is a narcpod before trying to access getPosition #6529

Merged
merged 1 commit into from
Feb 11, 2025
+1 −1
Merged

fix: check if it is a narcpod before trying to access getPosition #6529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megamek/src/megamek/common/GameDatasetLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ private void append(Game game, AbstractAttackAction attackAction, boolean withHe
if (target != null ) {
targetId = target.getId() + "";
targetType = target.getClass().getSimpleName();
targetCoords = target.getPosition() != null ? target.getPosition().toTSV() : "-1\t-1";
targetCoords = !(target instanceof INarcPod) && target.getPosition() != null ? target.getPosition().toTSV() : "-1\t-1";
if (target instanceof Entity entity) {
targetPlayerId = entity.getOwner().getId() + "";
targetRole = entity.getRole() == null ? UnitRole.NONE.name() : entity.getRole().name();
Expand Down