fix: check if it is a narcpod before trying to access getPosition #6529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aparently 19 years ago someone had the idea that NarcPod is a "targetable" but it has no "position" and you should not ask its position, and if you do it throws a runtime exception at you. This is... Unexpected and unwelcomed, as it implements a common API for things that can be targeted I imagined that anything that implements this API would... well.. be targetable, narcpods are not, and if you dont first check if it is not a narcpod you cannot safely check the coordinates of an attack action.
So, this PR handles that problem in the dataset logger.