Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve copy-to-clipboard, fix home link, clean up exampleSite #37

Merged
merged 5 commits into from
Aug 24, 2021

Conversation

helfper
Copy link

@helfper helfper commented Aug 20, 2021

Some fixes and clean-ups:

  • copy-to-clipboard icon looked stretched
  • Home link didn't work correctly when base URL has some path
  • Typo in custom theme's variable: --MENU-HOME-LINK-HOVERED-color
  • Fixed some exampleSite typos and other minor clean-ups

@McShelby
Copy link
Owner

Thanks for the patch, I'll take a look into it.

Some hint for the next time: please submit separtate PRs for each individual issue. This makes cherry picking easier in case a maintainer don't want to merge everything.

@McShelby
Copy link
Owner

I've tried to review your patch but it is really hard with all the little things that got fixed.

I'ld really appreciate it, if you could split up each individual feature fix into a separate patch. It doesn't need to be a PR.

@McShelby
Copy link
Owner

I've fixed all the documentation stuff, whitespace issues and code block / code fence formatting in the 2.0.0 branch.

@helfper: What's left to do is integrating the bug fixes of your patch.

@helfper
Copy link
Author

helfper commented Aug 24, 2021

@McShelby I've split the PR into multiple commits. Let me know if you prefer separate PRs instead.

@McShelby
Copy link
Owner

I've checked all patches and so far everything looks fine.
@helfper: Just a final question: What was the reason to require a newer hugo version for netlify?

@McShelby
Copy link
Owner

I may answer myself: Because with the current setup at https://relearn.netlify.app/tags/ the page doesn't show any content.

@McShelby McShelby linked an issue Aug 24, 2021 that may be closed by this pull request
@McShelby McShelby merged commit 449708a into McShelby:2.0.0 Aug 24, 2021
@helfper
Copy link
Author

helfper commented Aug 24, 2021

Yes, taxonomy kinds were renamed in Hugo 0.73.0: https://github.com/gohugoio/hugo/releases/tag/v0.73.0
The theme had already been updated to reflect that (somewhat incorrectly in header.html though): a7a2954
But the Hugo version was not changed in Netlify, so things got out of sync.

@helfper helfper deleted the clean-up branch August 24, 2021 17:13
@McShelby McShelby added the bug Something isn't working label Mar 23, 2022
@McShelby McShelby added this to the 2.0.0 milestone Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants