Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: fix home link when base URL has some path #44

Closed
McShelby opened this issue Aug 24, 2021 · 0 comments · Fixed by #37 or #47
Closed

theme: fix home link when base URL has some path #44

McShelby opened this issue Aug 24, 2021 · 0 comments · Fixed by #37 or #47
Assignees
@McShelby
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@McShelby
Copy link
Owner

McShelby commented Aug 24, 2021 •
edited
Loading

Logo and home button may point to the wrong url in case of a base URL.
Also search result links are broken in case a base URL is given.

Reference: matcornic/hugo-theme-learn#507
Reference: matcornic/hugo-theme-learn#504
Reference: matcornic/hugo-theme-learn#468
@McShelby McShelby self-assigned this Aug 24, 2021
@McShelby McShelby added the bug Something isn't working label Aug 24, 2021
@McShelby McShelby added this to the 2.0.0 milestone Aug 24, 2021
@McShelby McShelby linked a pull request Aug 24, 2021 that will close this issue
Improve copy-to-clipboard, fix home link, clean up exampleSite #37
Merged
@McShelby McShelby linked a pull request Aug 25, 2021 that will close this issue
Fix search with relativeURLs #47
Merged
@McShelby McShelby reopened this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@McShelby McShelby

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
1 participant
@McShelby