-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCM calculation with very long IV #5213
Merged
gilles-peskine-arm
merged 9 commits into
Mbed-TLS:development
from
tom-cosgrove-arm:pr_4950
Nov 22, 2021
Merged
Fix GCM calculation with very long IV #5213
gilles-peskine-arm
merged 9 commits into
Mbed-TLS:development
from
tom-cosgrove-arm:pr_4950
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
An initialization vector IV can have any number of bits between 1 and 2^64. So it should be filled to the lower 64-bit in the last step when computing ghash. Signed-off-by: openluopworld <luopengxq@gmail.com>
An initialization vector IV can have any number of bits between 1 and 2^64. So it should be filled to the lower 64-bit in the last step when computing ghash. Signed-off-by: openluopworld <luopengxq@gmail.com>
An initialization vector IV can have any number of bits between 1 and 2^64. So it should be filled to the lower 64-bit in the last step when computing ghash. Signed-off-by: openluopworld <luopengxq@gmail.com>
Co-authored-by: davidhorstmann-arm <70948878+davidhorstmann-arm@users.noreply.github.com> Signed-off-by: openluopworld <luopengxq@gmail.com>
…tly. An initialization vector IV can have any number of bits between 1 and 2^64. So it should be filled to the lower 64-bit in the last step when computing ghash. Signed-off-by: openluopworld <luopengxq@gmail.com>
Signed-off-by: openluopworld <wuhanluop@163.com>
Signed-off-by: openluopworld <wuhanluop@163.com>
Signed-off-by: openluopworld <wuhanluop@163.com>
4 tasks
davidhorstmann-arm
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
davidhorstmann-arm
added
bug
component-crypto
Crypto primitives and low-level interfaces
size-s
Estimated task size: small (~2d)
needs-backports
Backports are missing or are pending review and approval.
labels
Nov 22, 2021
gilles-peskine-arm
approved these changes
Nov 22, 2021
gilles-peskine-arm
added
needs-ci
Needs to pass CI tests
approved
Design and code approved - may be waiting for CI or backports
and removed
needs-backports
Backports are missing or are pending review and approval.
labels
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Design and code approved - may be waiting for CI or backports
bug
component-crypto
Crypto primitives and low-level interfaces
needs-ci
Needs to pass CI tests
size-s
Estimated task size: small (~2d)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4884
An initialization vector IV can have any number of bits between 1 and
2^64. So it should be filled to the lower 64-bit in the last step
when computing ghash.
This is PR #4950, rolled back to just before the last merge - originator timeout
Backports: 2.2x, 2.16