Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.x: Fix GCM calculation with very long IV #5132

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Backport 2.x: Fix GCM calculation with very long IV #5132

merged 1 commit into from
Nov 22, 2021

Conversation

openluopworld
Copy link
Contributor

@openluopworld openluopworld commented Nov 4, 2021

Trivial backport of #4950

2^64. So it should be filled to the lower 64-bit in the last step
when computing ghash.

Signed-off-by: openluopworld <wuhanluop@163.com>
@gilles-peskine-arm gilles-peskine-arm changed the title bugfix: if the len of iv is not 96-bit, y0 can be calculated incorrectly. Backport 2.x: Fix GCM calculation with very long IV Nov 4, 2021
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of #4950

@gilles-peskine-arm gilles-peskine-arm added bug Community component-crypto Crypto primitives and low-level interfaces single-reviewer This PR qualifies for having only one reviewer labels Nov 4, 2021
@gilles-peskine-arm gilles-peskine-arm added the approved Design and code approved - may be waiting for CI or backports label Nov 4, 2021
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - cheers!

@gilles-peskine-arm gilles-peskine-arm merged commit 989a4e9 into Mbed-TLS:development_2.x Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants