[pull] master from apple:master #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…k to thin and thick to thick representations on subtype context
…rtain representation convertions do not crash
Co-authored-by: Xiaodi Wu <13952+xwu@users.noreply.github.com>
…on map when computing necessary bindings of abstract cnditional requirements SR-12853
This changes the hash from the Python `hash` function to SHA1. Python 3 adopted SIP as the hashing algorithm which changed the hash results. We could no longer use a different python interpreter across the builds. A stable hashing algorithm allows easier migration.
…of a global variable
It is too slow, rdar://64215520
…n type has error type
…-build is enabled.
Explicitly use the path to pyhon2.7 (although the tool can support python 3.x, the path is much much unwieldy as `"C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python37_64\python.exe"`
…S stdlib. rdar://problem/64301166
Private and internal classes shouldn't have ABI constraints on their concrete vtable layout, so if methods don't have overrides in practice, we can elide their vtable entries.
vim: improve syntax highlighting rules
but Solution node->type map is all or nothing, so can be cheaper.
During witness table instantiation, the witness table is constructed several sources: the pattern, the resilient witnesses, the private data, and default implementations. The private data area is the only one that was being zeroed out; the rest we rely on always filling in the data from the conformance descriptor and provided info. However, witness table instantiation uses the presence of a NULL pointer for a particular witness in the resulting table to indicate that no witness fulfilled that requirement, so that it can fill in the default witnesss. Except that, without zeroing that part of the table beforehand, we aren't guaranteed to have a NULL pointer for witness entries that the client (protocol conformance) did not know about at the time it was compiled. Zero out the entire witness table so default implementations can be filled in appropriately. Fixes rdar://problem/64295849.
The CI is switching to ICU 67 since there are fixes in the latter version of ICU that are needed. This should be further improved in the future to possibly use the the unicode.org releases.
This reverts commit 499ed05. This changes the num-threads passed to 1 to avoid a multithreaded output issue on windows
Allow user control over libxml2 usage via `LLVM_ENABLE_LIBXML2` rather than assuming that if it is found, it should be enabled.
…-default-zeroing [Runtime] Zero out the entire witness table during instantiation.
[Sema] Solution nodeTypes from MapVector to DenseMap.
…epresentation conversions.
Update WindowsBuild.md
build: do not assume that XML2 should be enabled
…npect-products [Gardening] Ignored Package.resolved for swift-inspect.
Ignore onFastPath builtin while looking for valid static initializer of a global variable
…ditionalRequirements IRGen: Lookup the conformance of an archetype in the right substitution map when computing necessary bindings of abstract cnditional requirements
…-for-all-modules reland: Emit coverage mappings for all modules
[test] Handle architecture aliasing for OpenBSD.
Call prepareExtensions to make sure we load in any new extensions brought in by modules loaded after-the-fact. This isn't an issue for normal compilations as we load all the modules up-front in import resolution, but clients such as the LLDB REPL may load in modules later. Resolves rdar://64040436.
Fix the hardcoded Swift AST section / segment name for Mach-O
[SourceKit][SR-12837] Add effective access level of references
[SR-12723][Sema] Validate function type param representations thick-to-thin conversions
Disable tests that occasionally flake on Linux. SR-13021 tracks re-enabling these tests.
Now that we use the LLVM mono-repo, we don't need to worry about clang's version number. Also, git has the ability to estimate the safe number of digits a hash can be truncated to and now git estimates that large projects like LLVM and Linux "require" 12 digits for safe commit hash abbreviation. Let's stay a little ahead of the curve and statically truncate to 15.
The rule-of-zero is your friend. Also, switch to `class` and make the `value` private while we're touching these types.
[Basic] Revise version printing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )