[Sema] Solution nodeTypes from MapVector to DenseMap. #32365
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstraintSystem node->type map requires ordering because it is a stack that can be partially undone, but Solution node->type map is all or nothing, so can be cheaper with just a DenseMap.
Impact is small, but this does save ~5% of the time in Sema for expressions with a whole lot of ASTNodes, such as array literals, e.g. https://bugs.swift.org/browse/SR-8314.