Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPC using HW SPI Class + Finish DMA transfer for LPC #19191

Merged
merged 8 commits into from
Sep 10, 2020
Merged

LPC using HW SPI Class + Finish DMA transfer for LPC #19191

merged 8 commits into from
Sep 10, 2020

Conversation

rhapsodyv
Copy link
Sponsor Member

@rhapsodyv rhapsodyv commented Aug 29, 2020 •
edited
Loading

Description

This finished the work started in #19139

  • Fix DMA transfer for repeat mode
  • Touch + TFT + Onboard SD = fully working sharing the same Hardware SPI class - Tested in SKR 1.4 Turbo
  • LCD + LCD SD = fully working sharing the same Hardware SPI class - Tested in SKR 1.4 Turbo

It depends on this PR for the lpc framework: p3p/pio-framework-arduino-lpc176x#43
That PR needs to be merged before this one.

@p3p, Marlin CI will break until the LPC framework get updated :-)

I think I'm done with LPC! ✅ 🚀

Benefits

  • Fully DMA for LPC
  • Fully HW SPI for LPC

Configurations

For TFT + TOUCH + ONBOARD SD

TFT_480x320_SPI ou SPI_GRAPHICAL_TFT
TOUCH_SCREEN
SDSUPPORT
SDCARD_CONNECTION ONBOARD
BOARD_BTT_SKR_V1_4_TURBO

For LCD + LCD SD

REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER
SDSUPPORT
BOARD_BTT_SKR_V1_4_TURBO

Related Issues

#19139
p3p/pio-framework-arduino-lpc176x#43

@sjasonsmith sjasonsmith added A: LPC176x S: Don't Merge Work in progress or under discussion. PR: Improvement labels Aug 29, 2020
@rhapsodyv rhapsodyv force-pushed the lpc-using-hardware-spi branch 2 times, most recently from a7dce59 to bfcc17d Compare September 8, 2020 14:48
@rhapsodyv
Copy link
Sponsor Member Author

@p3p has merged my PR and released a new version of the LPC framework, with DMA and no-minc support!! CI is green!

I think this PR could be merged. In my tests, everything is working.

@sjasonsmith sjasonsmith removed the S: Don't Merge Work in progress or under discussion. label Sep 8, 2020
@thinkyhead thinkyhead merged commit 160f70b into MarlinFirmware:bugfix-2.0.x Sep 10, 2020
Vertabreak pushed a commit to Vertabreak/Marlin that referenced this pull request Sep 10, 2020
Merge pull request #326 from MarlinFirmware/bugfix-2.0.x
3251b17 
LPC: Finish DMA transfer, use HW SPI class (MarlinFirmware#19191)
@rhapsodyv rhapsodyv deleted the lpc-using-hardware-spi branch October 25, 2020 00:30
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
@rhapsodyv @vgadreau
LPC: Finish DMA transfer, use HW SPI class (MarlinFirmware#19191)
3f09f99
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
@rhapsodyv @thinkyhead
LPC: Finish DMA transfer, use HW SPI class (MarlinFirmware#19191)
42619a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: LPC176x C: LCD & Controllers PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhapsodyv @thinkyhead @thisiskeithb @sjasonsmith