-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with quiz next button skipping questions #2312
Conversation
Hi @lesterong thanks very much for the work on this PR! |
@yucheng11122017, noted on that! I have edited my comment with the full template. Also, may I clarify what unit tests to add? It seems like the tests for the |
hi @lesterong! the tests were disabled due to some unexpected behaviour with setTimeout being used in the tests causing CI to fail sometimes. perhaps you could test the fix locally but skip it when you commit so that we can unskip them when we solve #2238 |
Checked on https://deploy-preview-2312--markbind-master.netlify.app/userguide/components/others#quizzes and the behavior seems to be corrected 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @lesterong
LGTM! I've checked out the tests as well and it seems to work as intended. Thanks @lesterong! |
@all-contributors please add lesterong for code |
I've put up a pull request to add @lesterong! 🎉 |
What is the purpose of this pull request?
Overview of changes:
Only allow the click event on the Next button in Quiz to be triggered once. Resolves #2188.
Anything you'd like to highlight/discuss:
NIL
Testing instructions:
NIL
Proposed commit message: (wrap lines at 72 characters)
Fix Quiz next button skipping questions
Checklist: ☑️