Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky quiz and scroll-to-top button tests #2244

Merged
merged 5 commits into from
Mar 28, 2023

Conversation

itsyme
Copy link
Contributor

@itsyme itsyme commented Mar 28, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Disables with all questions marks 3/4 correct shows ending screen in Quiz and button lightens after user stops scrolling in ScrollTopButton which fails occasionally in CI. Temporary fix to #2238

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Disable tests that fail in CI ocassionally


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@tlylt
Copy link
Contributor

tlylt commented Mar 28, 2023

@itsyme Still have problems
image

@itsyme
Copy link
Contributor Author

itsyme commented Mar 28, 2023

I have skipped all questions with setTimeout used in Quiz.spec.js and ScrollTopButton.spec.js in the latest commit just to be sure

Copy link
Contributor

@tlylt tlylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itsyme. Merging this to avoid affecting all the ready PRs that are in the pipeline. We should definitely try to fix this ASAP and revert the need for skipping.

@tlylt tlylt added this to the v4.1.1 milestone Mar 28, 2023
@tlylt tlylt changed the title Disable tests that fail in CI occasionally Disable flaky quiz and scroll-to-top button tests Mar 28, 2023
@tlylt tlylt merged commit 0e9b784 into MarkBind:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants