[Changelog] Add Sprint 97 and Hammer Beta1 #295
Conversation
|
@miq-bot add_label documentation |
|
@miq-bot add_label hammer/no |
CHANGELOG.md
Outdated
|
|
||
| ## Unreleased as of Sprint 91 ending 2018-07-30 | ||
| ### Removed | ||
| - Remove non-existing "server-policy" yum group [(#268)](https://github.com/ManageIQ/manageiq-appliance-build/pull/268) |
There was a problem hiding this comment.
This line should be removed as this fix first appeared in Gaprindashvili-4.
There was a problem hiding this comment.
How did it even get here? This wasn't in an "unreleased" section before this PR ...
|
It looks some PRs are missing... e.g. #277 |
|
@simaishi that should probably be in a Gaprindashvili release though right? I would prefer "fixes" to the changelog be made in separate PRs. |
|
No, that's in Hammer Beta1, so it got missed in the PR that went to Hammer branch too. |
[skip ci]
|
What probably happened with PR277, was the Milestone label was not added. As such, it may not have shown up in the list of PRs for that particular sprint. |
|
@JPrause I think Sprint 92 and/or Sprint 93 got missed.. Looks like there are a few other PRs missing from the same time period. Regardless, they can be added now as needed! |
|
@simaishi there are certain PRs (based on labels) that not included in the changelog. This is intentional, and has been in place since before I've been doing the changelogs. So I'd say, let's move on and get these all merged. |
|
@JPrause I really hope we'll change the process to use a label for changelog. Otherwise, the reviewers can't tell why certain PR is included in the changelog and not, and questions like this will come up again. It won't matter if we're going to change the process, but if not, can you at least document how label affects changelogs? Please do add #277 and #276 (I'm not sure why this isn't listed as this is labeled as |
|
@simaishi sure and no problem. Even (and hopefully we do) after we implement a label system, the reviewer/merger can always request a particular PR be added, if they forgot to add the changelog label at merge time. I'll add the PRs you identified to this PR. In the case of PR277, there was no milestone set. It never showed up on my list because of that omission. PR276 was excluded since it has a label of dependencies. (I'll add the list of labels that are excluded to the process doc) |
|
Checked commits JPrause/manageiq-appliance-build@94e6b0a~...9d11a32 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
[skip ci]