Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 8 #276

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Update to node 8 #276

merged 2 commits into from
Aug 9, 2018

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Aug 9, 2018

This PR adds a repo(https://rpm.nodesource.com/pub_8.x/el/7/x86_64/) during build from which we can install an rpm (nodesource-release) which brings a repo file which allows us to install nodejs version 8.

This also removes npm because the new node package also provides /usr/bin/npm

[root@localhost vmdb]# rpm -qa | grep node
nodesource-release-el7-1.noarch
nodejs-8.11.3-1nodesource.x86_64
[root@localhost vmdb]# rpm -qa | grep npm
[root@localhost vmdb]# which npm
/usr/bin/npm
[root@localhost vmdb]# yum provides /usr/bin/npm
2:nodejs-8.11.3-1nodesource.x86_64 : JavaScript runtime
Repo        : nodesource
Matched from:
Filename    : /usr/bin/npm

1:npm-3.10.10-1.6.14.3.1.el7.x86_64 : Node.js Package Manager
Repo        : epel
Matched from:
Filename    : /usr/bin/npm

cc @himdel

This provides a repo from which we can install nodejs version 8
/usr/bin/npm is provided in the new node package so it doesn't
need to be installed separately from EPEL
@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2018

Checked commits carbonin/manageiq-appliance-build@8cb67f8~...a62aa07 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit b230af5 into ManageIQ:master Aug 9, 2018
@Fryguy Fryguy added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants