Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rxFrequencies #107

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix rxFrequencies #107

wants to merge 6 commits into from

Conversation

jusack
Copy link
Contributor

@jusack jusack commented Oct 23, 2024

Closes #105, maybe fixes #101

I changed some functions in Derived.jl to use FFTW or built-in julia functions and added tests, which would have caught issue #105

@jusack jusack requested a review from nHackel October 23, 2024 08:50
@tknopp
Copy link
Member

tknopp commented Oct 23, 2024

yes, using rfftfreq is definitely better.

@jusack
Copy link
Contributor Author

jusack commented Oct 23, 2024

The first test fail was Aqua finding am ambiguity between Base and Interpolations, I bumped the Aqua compat where the default behaviour is now to only look at the tested package.
However, now the test on the UniformRandomPositions fails on Julia 1.11 (and not on 1.10). I opened an issue on that (#108)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rxFrequencies produces wrong result getMeasurements does not work with background measurements
2 participants